Add support for default visible dimensions and measures in dashboard config #3974
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AdityaHegde
force-pushed
the
adityahegde/default-measures-and-dimensions
branch
from
af8e061 to
f6ba43b
Compare
AdityaHegde
changed the title
Comment on lines
187
to
191
| repeated DimensionV2 dimensions = 6; | ||
| repeated string default_selected_dimensions = 18; | ||
| // Measures in the metrics view | ||
| repeated MeasureV2 measures = 7; | ||
| repeated string default_selected_measures = 19; |
There was a problem hiding this comment.
What about just default_dimensions and default_measures? We also have default_time_range instead of default_selected_time_range, and same for comparison defaults.
There was a problem hiding this comment.
Either is fine with me. I just kept the same field as product requested.
There was a problem hiding this comment.
Changed after consulting product.
| @@ -425,6 +445,7 @@ func (p *Parser) parseMetricsView(ctx context.Context, node *Node) error { | |||
| Unnest: dim.Unnest, | |||
| }) | |||
| } | |||
| spec.DefaultSelectedDimensions = slices.Clone(tmp.DefaultSelectedDimensions) | |||
There was a problem hiding this comment.
Why is slices.Clone needed here?
There was a problem hiding this comment.
We dont need it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addressing Support default selected dimensions and measures
default_measuresanddefault_dimensionsin dashboard config