Read-only filter chips #3998
Merged
Read-only filter chips #3998
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ate alert" dialog
AdityaHegde
approved these changes
Feb 12, 2024
| let topListQuery: ReturnType<typeof getFilterSearchList> | undefined; | ||
|
|
||
| $: if (isOpen) { | ||
| topListQuery = getFilterSearchList(StateManagers, { |
There was a problem hiding this comment.
We should disable this query if it is readonly. Even though isOpen is not set to true right now we might end up changing it. Perhaps just a comment would be enough to make sure future devs will keep it in mind?
There was a problem hiding this comment.
Kk, I just added the conditional now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors the filter chips to accommodate the "read-only" mode that we need for the Create Alert dialog in PR #3881.
Here are the normal, interactive chips:
Here are the read-only versions:
