Add button for selecting pivot fields via dropdown #4020
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
briangregoryholmes
changed the title
djbarnwal
approved these changes
Feb 12, 2024
| measures: ({ metricsSpecQueryResult, dashboard }: DashboardDataSources) => { | ||
| const measures = | ||
| metricsSpecQueryResult.data?.measures?.filter( | ||
| (d) => d.name && dashboard.visibleMeasureKeys.has(d.name), |
There was a problem hiding this comment.
Wondering if we should only limit to visible measures and dimensions in the pivot. We don't have controls to change the visibility in the pivot view. Probably better if we show all available dimensions and measures cc @mindspank What do you recon we should do here?
There was a problem hiding this comment.
@djbarnwal Yes I would display all dimensions and measures
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a button to the pivot columns and rows drag lists that allows the user to select pivot fields via dropdown. To support this, the dimension and measure aggregators have been moved to the pivot selectors.