Rill Developer: add UI for external tables #4027
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Validated and tested, LGTM. |
AdityaHegde
approved these changes
Feb 16, 2024
| @@ -44,7 +44,7 @@ export function initBlankDashboardYAML(dashboardTitle: string) { | |||
| # Visit https://docs.rilldata.com/reference/project-files to learn more about Rill project files. | |||
|
|
|||
| title: "" | |||
| model: "" | |||
| table: "" | |||
There was a problem hiding this comment.
Why do we prefer table for the blank dashbaord?
There was a problem hiding this comment.
Because model only works for models, but table works for these external tables plus sources and models.
nishantmonu51
added
the
blocker
mindspank
pushed a commit
that referenced
this pull request
Feb 23, 2024
* Add external table page and navigation * Use `table` not `model` in generated dashboard YAML * Add "Autogenerate dashboard" action to header * Add "Autogenerate dashboard" action to context menu * Hide modeling for Druid connections * Only show sources for DuckDB connections * Terminology: use "table" not "external table" * Remove modeling layer for clickhouse driver * Add a `default_time_range` of "P4W" * Differentiate between models and tables in generated dashboard code * Fix placeholder for OLAP drivers that don't support modeling * Use selector `isModelingSupportedForCurrentOlapDriver` * Bugfix * Add navigation overflow/scroll when many tables * Only route to Welcome page for DuckDB OLAP driver * Add different onboarding steps for non-DuckDB OLAP drivers * Edit copy * Fix test (and slight test refactor) * Fix test * Fix lint * Filter out the managed tables (sources and models) --------- Co-authored-by: Nishant Bangarwa <nishant.monu51@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds UI to Rill Developer to enable exploring external tables. These are pre-existing tables in the user's OLAP driver (e.g. DuckDB, Clickhouse, Druid) and are not managed by Rill.
Specifically, this PR:
localhost:9009/table/{table-name}that shows a preview (up to 150 rows) of the selected tableCloses #4041
Remaining work:
TableColumnsandTableRows) aren't available for Druid