Fix delayed dashboard url state load #4035
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ericpgreen2
approved these changes
Feb 14, 2024
ericpgreen2
reviewed
Feb 14, 2024
| const metricsViewSchema = createQueryServiceMetricsViewSchema( | ||
| $runtime.instanceId, | ||
| metricViewName, | ||
| ); | ||
|
|
||
| function syncDashboardState() { |
There was a problem hiding this comment.
This function could be more clear if weren't a closure and instead accepted input parameters. With this PR, it's getting more complicated.
There was a problem hiding this comment.
Agree. A lot of this code might not be needed anymore. We should revisit this once when we refactor state managers.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Summary
Issue addressed:
Just after opening a dashboard with a url state that has non-default time range selected, changing the time grain for the 1st time will reset the time range to the default time range.
Details:
This is because there is a delay in url state applying to the dashboard store. This PR makes sure that the url state is loaded as soon as the store is created.
Steps to Verify