Update dashboard header layout and tab component #4063
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
briangregoryholmes
changed the title
ericpgreen2
reviewed
Feb 15, 2024
| @@ -97,20 +95,17 @@ | |||
| {#if mockUserHasNoAccess} | |||
| <div class="mb-3" /> | |||
| {:else} | |||
| <div class="-ml-3 px-1 pt-2 space-y-2"> | |||
| <div class="-ml-3 px- pt-2 space-y-2"> | |||
mindspank
pushed a commit
that referenced
this pull request
Feb 23, 2024
* update dashboard header and tab component * remove unused variables * typo
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The purpose of this PR was to simply add a
Betatag to the Pivot tab on the dashboard, but turned into one that refactors the Dashboard tab component with native functionality instead of extending headless-ui, whose limited functionality was presenting some issues. Additionally, this PR solves some layout oversights in the header component.