Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix invalid fetching state #4082

Merged
merged 1 commit into from
Feb 19, 2024
Merged

Fix invalid fetching state #4082

merged 1 commit into from
Feb 19, 2024

Conversation

djbarnwal
Copy link
Member

For cases where we have column dimensions and row dimension without any measures, the table view shows a fetching spinner. We should instead show the empty state for now

@djbarnwal djbarnwal changed the title Fix false positive fetching state Fix invalid fetching state Feb 17, 2024
@djbarnwal djbarnwal added Area:Pivot blocker A release blocker issue that should be resolved before a new release labels Feb 17, 2024
Copy link
Contributor

@mindspank mindspank left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@djbarnwal djbarnwal merged commit c799d1f into main Feb 19, 2024
6 checks passed
@djbarnwal djbarnwal deleted the fix/false-fetching-pivot branch February 19, 2024 15:47
mindspank pushed a commit that referenced this pull request Feb 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area:Pivot blocker A release blocker issue that should be resolved before a new release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants