Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve Alert History table #4195

Merged
merged 7 commits into from
Feb 28, 2024
Merged

Improve Alert History table #4195

merged 7 commits into from
Feb 28, 2024

Conversation

ericpgreen2
Copy link
Contributor

@ericpgreen2 ericpgreen2 commented Feb 28, 2024 •
edited
Loading

Improvements:

  • Updated chip copy to match mocks
  • Added error text in case of a Failed execution
  • Refactored the AlertHistoryStatusChip to use our Tag component

Some examples:

image
image
image

@ericpgreen2 ericpgreen2 self-assigned this Feb 28, 2024
@ericpgreen2 ericpgreen2 mentioned this pull request Feb 28, 2024
Closed
16 tasks
@AdityaHegde AdityaHegde merged commit 6e13efc into main Feb 28, 2024
6 checks passed
@AdityaHegde AdityaHegde deleted the update-alert-history-status-chip branch February 28, 2024 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AdityaHegde AdityaHegde AdityaHegde approved these changes

Assignees

@ericpgreen2 ericpgreen2

Labels
Area:Alerts
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ericpgreen2 @AdityaHegde