Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin sveltekit to 1.30.0 temporarily #4206

Merged
merged 1 commit into from
Feb 29, 2024
Merged

Conversation

AdityaHegde
Copy link
Collaborator

@AdityaHegde AdityaHegde commented Feb 29, 2024

Checklist

  • Manual verification
  • Unit test coverage
  • E2E test coverage
  • Needs manual QA?

Summary

Issue addressed:

Visiting either dev or cloud UIs would add an additional forward slash. This lead to issues in dashboard where state url was not getting applied. Also caused issues in certain redirects like alerts.

Details:

This was caused by a bug in sveltekit. We should ideally upgrade to 2.0.1 to get this fixed. But for now pinning to the last version where this is not broken, 1.30.0.

Steps to Verify

  1. After starting either dev or cloud UIs, visit the page from http://localhost:3000
  2. Navigating to different page shouldnt add the forward slash.
  3. In dashboard the stateful url should get populated.

@AdityaHegde AdityaHegde mentioned this pull request Feb 29, 2024
16 tasks
@AdityaHegde AdityaHegde merged commit 6b74f8f into main Feb 29, 2024
6 checks passed
@AdityaHegde AdityaHegde deleted the pin-sveltekit-version branch February 29, 2024 06:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants