Fix Go coverage #4219
Merged
Fix Go coverage #4219
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
himadrisingh
approved these changes
Mar 1, 2024
begelundmuller
added a commit
that referenced
this pull request
Mar 1, 2024
* Update Bookmarks API to support new designs (#4167) * Update Bookmarks API to support new designs * Update list bookmarks * Fix migration sql * Update to use shared/default for bookmarks * Fix edit bookmark query * Update list bookmark * Update API to use resource kind/name * Update default resource type * Set cookies to Lax (#4212) * Fix Go coverage (#4219) * Fix Go coverage * Whoops * Util for better HTTP error handling (#4220) * Util for better HTTP error handling * Self review * Add resource for chart and dashboard (#4197) * Add resource for chart and dashboard * Fix format * PR comments * API resource review --------- Co-authored-by: Aditya Hegde <adityahegderocks@gmail.com>
begelundmuller
added a commit
that referenced
this pull request
Mar 1, 2024
* draft commit * draft commit * permissions * review comments - more generic APIs * review comments - more generic APIs * review comments - more generic APIs * remove parsing metric * revert wrong change * comment change * API resource review (#4223) * Update Bookmarks API to support new designs (#4167) * Update Bookmarks API to support new designs * Update list bookmarks * Fix migration sql * Update to use shared/default for bookmarks * Fix edit bookmark query * Update list bookmark * Update API to use resource kind/name * Update default resource type * Set cookies to Lax (#4212) * Fix Go coverage (#4219) * Fix Go coverage * Whoops * Util for better HTTP error handling (#4220) * Util for better HTTP error handling * Self review * Add resource for chart and dashboard (#4197) * Add resource for chart and dashboard * Fix format * PR comments * API resource review --------- Co-authored-by: Aditya Hegde <adityahegderocks@gmail.com> --------- Co-authored-by: Benjamin Egelund-Müller <b@egelund-muller.com> Co-authored-by: Aditya Hegde <adityahegderocks@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The coverage test has been failing for some time with the following errors:
This appears to be a bug in Go that can be resolved by setting
GOEXPERIMENT=nocoverageredesign.This issue may provide guidance on when the change can be reverted: golang/go#55953.