Telemetry for success/failure of AI-based metrics view generation #4296
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
begelundmuller
added
the
blocker
esevastyanov
approved these changes
Mar 11, 2024
| if err != nil { | ||
| attrs = append(attrs, attribute.String("error", err.Error())) | ||
| } | ||
| s.activity.Record(ctx, activity.EventTypeLog, "ai_generated_metrics_view_yaml", attrs...) |
There was a problem hiding this comment.
This might be recorded as a metric and allowed in a filterSink as
sink := activity.NewFilterSink(intakeSink, func(e activity.Event) bool {
return e.EventType != activity.EventTypeMetric || name == "ai_generated_metrics_view_yaml_elapsed_ms"
})
not very elegant as it requires to maitain a list of allowed metric names. but ideally, we anyway need to create a list of constants that represent all registered application metric names so that it is possible to quickly check if there are any duplicate names
so it is up to you, i'm fine with the existing solution
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes https://github.com/rilldata/rill-private-issues/issues/186