Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enables the setting of feature flags via the rill.yaml file and updates the formatting expectations of localStorage keys to match the YAML and URL params.
rillYAML
andRillYAML
types in the platform codeAs an example, if you add (or remove) the following in your
rill.yaml
:The UI should respond immediately (after a debounce) to toggle that feature on or off. Adding something like
adminServer
would not enable that feature as this flag has been created withsystem
scope, but no warning is surfaced.A flag needs only to be set in one location to be enabled, so if you have
customDashboards
set in the URL, localStorage and YAML, then it won't be turned off in the UI until it's removed from all three locations.While this will not be a widely used feature, I would argue that we should remove the ability to set flags in the URL/localStorage now that it's enabled in the project YAML.