Add vega lite spec validation for charts #4336
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AdityaHegde
force-pushed
the
adityahegde/custom-chart-vega-validation
branch
2 times, most recently
from
5e6eaf9 to
73a8e44
Compare
AdityaHegde
force-pushed
the
adityahegde/custom-chart-vega-validation
branch
from
73a8e44 to
96c93cf
Compare
begelundmuller
requested changes
Mar 14, 2024
| @@ -13,6 +18,8 @@ type ChartYaml struct { | |||
| VegaLite string `yaml:"vega_lite"` | |||
| } | |||
|
|
|||
| var vegaLiteSchema = jsonschema.MustCompile("https://vega.github.io/schema/vega-lite/v5.json") | |||
There was a problem hiding this comment.
Let's vendor this spec into our repo (so charts work on slow/no internet connection).
Would suggest putting it in runtime/compilers/rillv1/data/vega-lite-v5.json and using the embed package here to build it into the binary.
AdityaHegde
force-pushed
the
adityahegde/custom-chart-vega-validation
branch
from
63d6912 to
204f115
Compare
begelundmuller
approved these changes
Mar 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds vega lite spec validation based on the spec : https://vega.github.io/schema/vega-lite/v5.json
We are using github.com/santhosh-tekuri/jsonschema/v5 to run the validation.