Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Runtime: Check alerts on external tables every 10 minutes by default #4347

Merged
merged 1 commit into from
Mar 14, 2024

Conversation

begelundmuller
Copy link
Contributor

@begelundmuller begelundmuller commented Mar 14, 2024

  • Adds a streaming property to a metrics view's state. If true, it indicates that data may change without reconcile triggering.
  • Sets streaming to true for all metrics views that don't reference a source or model.
  • Makes alerts that reference a streaming metrics view automatically check every 10 minutes.
  • Changes the alert logic to exit early if the watermark has not advanced (to reduce number of expensive alert check queries).
  • Also fixes an issue where alerts created through the admin APIs did not have watermark: inherit (so they would use the current time instead of the metric view's watermark).

Closes https://github.com/rilldata/rill-private-issues/issues/212

@AdityaHegde AdityaHegde merged commit 6425abe into main Mar 14, 2024
9 checks passed
@AdityaHegde AdityaHegde deleted the begelundmuller/alerts-external-tables-10-mins branch March 14, 2024 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants