Alerts: Fix data at watermark boundary is excluded #4348
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AdityaHegde
reviewed
Mar 15, 2024
| @@ -114,6 +114,10 @@ func (q *ResourceWatermark) resolveMetricsView(ctx context.Context, rt *runtime. | |||
| } | |||
|
|
|||
| if !t.IsZero() { | |||
| // Hacky workaround for the following issue: the watermark is used as the *exclusive* upper bound for time ranges. | |||
| // We need to add a small delta to ensure the row with the watermark is included in the result. | |||
| t = t.Add(time.Second) | |||
There was a problem hiding this comment.
Would just a ms be enough?
There was a problem hiding this comment.
I tried it and it didn't work outright with ClickHouse – apparently they have timestamps at second granularity by default
AdityaHegde
approved these changes
Mar 15, 2024
nishantmonu51
pushed a commit
that referenced
this pull request
Mar 15, 2024
* Alerts boundary fix * Alert error info log * Wording * Fix test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also includes some minor comment and logging improvements in the alerts reconciler.
Closes https://github.com/rilldata/rill-private-issues/issues/198.