Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Runtime: APIs to get connector details for a project #4363

Merged
merged 12 commits into from
Apr 3, 2024

Conversation

begelundmuller
Copy link
Contributor

@begelundmuller begelundmuller commented Mar 16, 2024

This PR adds three new APIs:

  • ListConnectorDrivers: returns metadata about all connector drivers implemented in the runtime, including specs of the config properties they support. It replaces the previous ListConnectors API.
  • AnalyzeConnectors: parses the project files and returns a complete breakdown of all connectors declared or referenced in the project, as well as the values of their config properties (broken down by source, e.g. rill.yaml or .env).
  • ListNotifierConnectors: is an API for getting the connectors that can be used as notifiers. It's designed specifically for use in the cloud UI to determine which alert/report destinations are available. Unlike AnalyzeConnectors, it does not require admin-level permissions (and is much faster). Note: It will not work correctly until this PR merges: Slack integration for alerts and reports #4371.

Closes https://github.com/rilldata/rill-private-issues/issues/216

@begelundmuller begelundmuller marked this pull request as ready for review March 26, 2024 15:37
@begelundmuller begelundmuller self-assigned this Mar 26, 2024
@begelundmuller begelundmuller requested a review from k-anshul April 1, 2024 10:01
runtime/connections.go Show resolved Hide resolved
runtime/drivers/s3/s3.go Show resolved Hide resolved
@begelundmuller begelundmuller requested a review from k-anshul April 3, 2024 11:45
@k-anshul k-anshul merged commit c5b80fa into main Apr 3, 2024
7 checks passed
@k-anshul k-anshul deleted the begelundmuller/connectors-apis branch April 3, 2024 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants