Unified artifact store for storing path to resource map #4396
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AdityaHegde
force-pushed
the
adityahegde/folder-structure-resource-map
branch
from
697faa9 to
e04c3f9
Compare
ericpgreen2
requested changes
Mar 26, 2024
web-common/src/features/entity-management/file-artifacts-store-new.ts
Outdated
Show resolved
Hide resolved
web-common/src/features/entity-management/file-artifacts-store.ts
Outdated
Show resolved
Hide resolved
web-common/src/features/entity-management/file-artifacts-store.ts
Outdated
Show resolved
Hide resolved
web-common/src/features/entity-management/file-artifacts-store.ts
Outdated
Show resolved
Hide resolved
web-common/src/features/entity-management/file-artifacts-store.ts
Outdated
Show resolved
Hide resolved
web-common/src/features/entity-management/file-artifacts-store.ts
Outdated
Show resolved
Hide resolved
web-common/src/features/entity-management/file-artifacts-store.ts
Outdated
Show resolved
Hide resolved
web-common/src/features/entity-management/file-artifacts-store.ts
Outdated
Show resolved
Hide resolved
web-common/src/features/entity-management/file-artifacts-store.ts
Outdated
Show resolved
Hide resolved
AdityaHegde
force-pushed
the
adityahegde/folder-structure-resource-map
branch
from
7e9f5a2 to
059dcd2
Compare
AdityaHegde
force-pushed
the
adityahegde/folder-structure-resource-map
branch
from
f8ebd90 to
3794582
Compare
ericpgreen2
reviewed
Mar 27, 2024
ericpgreen2
reviewed
Mar 27, 2024
ericpgreen2
reviewed
Mar 27, 2024
web-common/src/features/entity-management/file-artifacts-store.ts
Outdated
Show resolved
Hide resolved
ericpgreen2
approved these changes
Mar 27, 2024
AdityaHegde
force-pushed
the
adityahegde/folder-structure-resource-map
branch
from
db9e766 to
e667c7c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We had 2 store to save information about a file artifact :
fileArtifactsStoreandresourcesStore.This PR merges the 2 and moves to the class way of storing data.
Tries to parse the file to infer
kindandnameif a resource doesnt exist.