Upgraded gosnowflake as v1.8.0 has an issue with arrow batches #4408
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
esevastyanov
changed the title
nishantmonu51
approved these changes
Mar 23, 2024
begelundmuller
requested changes
Mar 25, 2024
There was a problem hiding this comment.
Looking at this, it seems like there's an error scenario where the writeGrp fails early (e.g. because of missing file permissions or a storage limit error), but the fetchGrp keeps downloading for a long time.
Similarly, this PR removes the ctx check in the writeGrp goroutine, which might lead to a lot of redundant writing if the fetchGrp fails.
I think this can be solved by using a single errgroup to coordinate all the goroutines (and having a if ctx.Err() != nil check inside the for-loop of the writing goroutine).
begelundmuller
approved these changes
Mar 25, 2024
nishantmonu51
pushed a commit
that referenced
this pull request
Mar 25, 2024
* Reverted gosnowflake as v1.8.0 has an issue with arrow batches * Upgraded to a specific gosnowflake commit that fixes the issue * Fixed an issue causing writeGrp to stop early with "context cancelled" * Described the reason behind the version upgrade * Simplified by moving fetch and write into a single goroutine
AndrewRTsao
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
snowflakedb/gosnowflake#1068