Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Runtime : Support multiple schemas with one live connection #4444

Merged
merged 28 commits into from
Apr 6, 2024
Merged

Runtime : Support multiple schemas with one live connection #4444

merged 28 commits into from
Apr 6, 2024

Conversation

k-anshul
Copy link
Member

@k-anshul k-anshul commented Mar 26, 2024 •
edited by ericpgreen2
Loading

  1. Added two new optional fields, database and db_schema, in metrics_view definition.
  2. Added support for specifying database and schema in information_schema lookup calls and profiling APIs.

TBD : Add similar support for druid.

@k-anshul k-anshul self-assigned this Mar 27, 2024
@k-anshul k-anshul marked this pull request as ready for review March 28, 2024 06:11
@nishantmonu51 nishantmonu51 added the blocker A release blocker issue that should be resolved before a new release label Mar 28, 2024
begelundmuller
begelundmuller requested changes Mar 28, 2024
View reviewed changes
proto/rill/runtime/v1/queries.proto Outdated Show resolved Hide resolved
proto/rill/runtime/v1/api.proto Outdated Show resolved Hide resolved
runtime/drivers/clickhouse/information_schema.go Outdated Show resolved Hide resolved
runtime/drivers/clickhouse/information_schema.go Outdated Show resolved Hide resolved
runtime/server/generate_metrics_view.go Outdated Show resolved Hide resolved
begelundmuller
begelundmuller requested changes Mar 29, 2024
View reviewed changes
runtime/drivers/clickhouse/information_schema.go Outdated Show resolved Hide resolved
runtime/drivers/clickhouse/information_schema.go Outdated Show resolved Hide resolved
runtime/queries/sqlutil.go Outdated Show resolved Hide resolved
runtime/queries/table_head.go Outdated Show resolved Hide resolved
runtime/server/generate_metrics_view.go Outdated Show resolved Hide resolved
runtime/validate.go Outdated Show resolved Hide resolved
begelundmuller
begelundmuller requested changes Mar 29, 2024
View reviewed changes
runtime/compilers/rillv1/parse_metrics_view.go Outdated Show resolved Hide resolved
runtime/drivers/clickhouse/information_schema.go Outdated Show resolved Hide resolved
runtime/drivers/clickhouse/information_schema.go Outdated Show resolved Hide resolved
runtime/drivers/druid/olap.go Outdated Show resolved Hide resolved
runtime/drivers/duckdb/information_schema.go Outdated Show resolved Hide resolved
runtime/drivers/olap.go Outdated Show resolved Hide resolved
k-anshul and others added 2 commits March 31, 2024 14:32
@k-anshul @begelundmuller
Apply suggestions from code review
779d812 
Co-authored-by: Benjamin Egelund-Müller <b@egelund-muller.com>
@k-anshul
nit
d0bb5e5
@k-anshul
Copy link
Member Author

This requires changes on UI to handle database and schema field.
Moving the PR to draft state till UI changes are ready.

@k-anshul k-anshul marked this pull request as draft March 31, 2024 09:19
k-anshul and others added 4 commits April 5, 2024 12:13
@k-anshul
Merge remote-tracking branch 'origin/main' into multiple_schemas
a7c2082
@ericpgreen2 @AdityaHegde @k-anshul
UI to support multiple schemas in an OLAP engine (#4515)
bb58c43 
* WIP commit

* Telemetry and source rename fixes (#4494)

* Fix behaviour event used on cloud

* Fix rename not working with olap table list

* Add a debounce to table list

* Fix debounce logic

---------

Co-authored-by: Eric P Green <ericpgreen2@gmail.com>

* Add `connector`, `database`, `databaseSchema` as inputs to a Table's `GenerateMetricsViewFile`

* Use "duckdb" connector for sources & models

* Use source & model connectors

* Bugfix

* Fix lint

* Fix lint

* Fix type imports

* Connector-specific fully-qualified table names

* Cleanup

* druid fix

* Cleanup

* Fix merge

---------

Co-authored-by: Aditya Hegde <adityahegderocks@gmail.com>
Co-authored-by: Anshul Khandelwal <anshulkhandelwal94@gmail.com>
@k-anshul
missing database and schema passing in new code
3d9d92c
@k-anshul
Merge remote-tracking branch 'origin/main' into multiple_schemas
f243936
@k-anshul k-anshul marked this pull request as ready for review April 6, 2024 16:08
@k-anshul k-anshul merged commit eb107a3 into main Apr 6, 2024
7 checks passed
@k-anshul k-anshul deleted the multiple_schemas branch April 6, 2024 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@begelundmuller begelundmuller begelundmuller approved these changes

@nishantmonu51 nishantmonu51 Awaiting requested review from nishantmonu51

Assignees

@k-anshul k-anshul

Labels
blocker A release blocker issue that should be resolved before a new release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@k-anshul @begelundmuller @nishantmonu51 @ericpgreen2