Support type hint and lint for metrics editor #4495
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I was confused when I first saw the error state. It looks like 1 popover (the error) is overlapping another popover (the documentation). |
ericpgreen2
reviewed
Apr 5, 2024
There was a problem hiding this comment.
This is great! My one worry is the hardcoded JSON schema will be a PITA to continually synchronize with the source-of-truth on the backend. Maybe there's a way we can generate it programmatically? @begelundmuller, thoughts?
19 tasks
ericpgreen2
approved these changes
Apr 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add type hints and lint for metrics editor. This PR also adds a JSON Schema for the metrics editor. In long term we would want to auto generate the schema from our Typescript types and doc strings. Since we are not there yet and not all types are consolidated, this JSON schema has be updated manually (along with docs and go validator) when we update our schema.
Future Improvements -