Runtime: Parallelize validation of metrics view dimensions and measures #4525
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AdityaHegde
approved these changes
Apr 8, 2024
AdityaHegde
pushed a commit
that referenced
this pull request
Apr 9, 2024
…es (#4525) * Runtime: Parallelize validation of metrics view dimensions and measures * Use a const * Make test deterministic
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For dashboards with many dimensions and measures, validating one-by-one can be very slow. This PR uses an errgroup to run validations concurrently. It applies a limit of 10 concurrent validations to avoid flooding the database with requests.