Remove stores from WatchRequestClient #4528
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AdityaHegde
approved these changes
Apr 10, 2024
| </script> | ||
|
|
||
| <svelte:window on:visibilitychange={handleVisibilityChange} /> |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors the
WatchRequestClientso that it no longer relies on writables internally. Instead, the methods have been updated to allow the same behavior externally (and slightly more explicitly).This was done as an incremental step to breaking up the monolithic
runtimestore (see: https://github.com/rilldata/rill-private-issues/issues/253#issuecomment-2028387087) and to help moving initial data fetching into+files. While my instinct is that we won't need actual stores for any of the runtime properties, this refactor is agnostic to that.This is a low risk refactor as, in Rill Developer (the only app in which this client is used currently), the host and instanceId do not change.
Note: I was a little unclear on the behavior of the ExponentialBackoffTracker. It only seems to be used in a catch block and the method in which it's used doesn't seem to result in different behavior.