Fix: Navigate after delete #4586
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ericpgreen2
approved these changes
Apr 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a variety of issues with the navigate after delete functionality.
deleteFileArtifactfunctionDashboardMenuItemscomponent to use dashboard routes instead of namesThe intended logic is as follows:
If you delete a file that you're not viewing, no navigation should take place. If you delete a file you are viewing, you should be directed to either the next available file of the same type or, if none are available, to the root page.
The details of this implementation will of course change with the file explorer and should allow us to abstract the
AssetsandMenuItemscomponents so that execution of this logic only exists in one place.