Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Runtime : Detach duckdb files with tx lock #4590

Merged
merged 6 commits into from
Apr 12, 2024
Merged

Runtime : Detach duckdb files with tx lock #4590

merged 6 commits into from
Apr 12, 2024

Conversation

k-anshul
Copy link
Member

Details here :

duckdb/duckdb#9342
duckdb/duckdb#11297

Even though we don't run any ATTACH & DETACH in parallel but I think that duckDB is also getting into this condition when running any information_schema call in parallel to DETACH operation.
We ensure all DETACH happen in isolation and sequentially using internal drivers tx lock.

@k-anshul k-anshul self-assigned this Apr 12, 2024
@k-anshul k-anshul added the blocker A release blocker issue that should be resolved before a new release label Apr 12, 2024
@begelundmuller begelundmuller merged commit e008a51 into main Apr 12, 2024
4 checks passed
@begelundmuller begelundmuller deleted the detach_with_tx branch April 12, 2024 15:36
k-anshul added a commit that referenced this pull request Apr 12, 2024
@k-anshul
Runtime : Detach duckdb files with tx lock (#4590)
e846b95 
* detach with tx

* detach with tx

* whole rename should be with tx = true

* cast_to_enum fix

* remove file even if attach failed

* fix duckdb to duckdb transfer
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@begelundmuller begelundmuller begelundmuller approved these changes

Assignees

@k-anshul k-anshul

Labels
blocker A release blocker issue that should be resolved before a new release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@k-anshul @begelundmuller