Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Admin: Fix version missing error for "rill deploy" from old versions #4604

Conversation

begelundmuller
Copy link
Contributor

@begelundmuller begelundmuller commented Apr 15, 2024

This PR makes CreateProject.ProdVersion default to latest on the server-side. This is necessary since older versions of Rill do not pass a ProdVersion.

Without this change, I'm getting this error during rill deploy from v0.42.3:

Error: create project failed with error rpc error: code = InvalidArgument desc = Malformed version:  (InvalidArgument)

@begelundmuller begelundmuller self-assigned this Apr 15, 2024
@begelundmuller begelundmuller added the blocker A release blocker issue that should be resolved before a new release label Apr 15, 2024
@begelundmuller begelundmuller merged commit 684ba20 into main Apr 15, 2024
6 checks passed
@begelundmuller begelundmuller deleted the begelundmuller/deploy-runtime-version-backwards-compatibility branch April 15, 2024 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocker A release blocker issue that should be resolved before a new release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants