Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update required fields in metrics schema #4607

Merged
merged 1 commit into from
Apr 15, 2024
Merged

Update required fields in metrics schema #4607

merged 1 commit into from
Apr 15, 2024

Conversation

djbarnwal
Copy link
Member

Updates the required fields based on -

The only required fields in a metrics def are:

  1. Exactly one of:
    model
    table

  2. Exactly one of:
    dimensions[*].column
    dimensions[*].property
    dimensions[*].expression

  3. measures[*].expression

Everything else is optional

https://rilldata.slack.com/archives/C02T907FEUB/p1713182860271179

@begelundmuller begelundmuller merged commit 8e7de8c into main Apr 15, 2024
6 checks passed
@begelundmuller begelundmuller deleted the fix/metrics-spec branch April 15, 2024 15:15
@begelundmuller begelundmuller added the blocker A release blocker issue that should be resolved before a new release label Apr 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@begelundmuller begelundmuller begelundmuller approved these changes

Assignees
No one assigned
Labels
blocker A release blocker issue that should be resolved before a new release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@djbarnwal @begelundmuller