Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Runtime: change error log to debug #4611

Merged
merged 2 commits into from
Apr 15, 2024
Merged

Runtime: change error log to debug #4611

merged 2 commits into from
Apr 15, 2024

Conversation

k-anshul
Copy link
Member

Here is my hypothesis around how detach can fail even in happy scenarios:

  1. The db file is created and we start ingesting data.
  2. The ingestion fails due to n number of reasons like duckdb memory limit exhausted, cancellation etc.
  3. In the cleanup we reopen db which re-attaches all files and removes directory with a db file but no version.txt file.
  4. Now the detach in cleanup will complain that db file does not exist.

@k-anshul k-anshul self-assigned this Apr 15, 2024
@begelundmuller begelundmuller merged commit 5e0fbb5 into main Apr 15, 2024
4 checks passed
@begelundmuller begelundmuller deleted the remove_error_log branch April 15, 2024 17:56
k-anshul added a commit that referenced this pull request Apr 16, 2024
* change error log to warn

* change error log to debug
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants