Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve drag drop UX in file explorer and other fixes #4619

Merged
merged 5 commits into from
Apr 17, 2024

Conversation

AdityaHegde
Copy link
Collaborator

@AdityaHegde AdityaHegde commented Apr 16, 2024

  • Improve drag drop UX.
    • Add a small distance before triggering the drag
    • Add icons to the dragged element.
    • Disable drag-drop for rill.yaml
  • Optimise the list files APIs to not make multiple calls.

Copy link
Contributor

@ericpgreen2 ericpgreen2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Drag-and-drop feels much better! (I tweaked the pixel buffer a bit)

The list files work seems to have caused the following regression:

  1. Add a blank file or folder in a subdirectory. It'll be named e.g. models/untitled_file or models/untitled_folder.
  2. Add another blank file or folder in the same subdirectory. It appears as if no new file/folder was created. Because the same name is being used untitled_file/untitled_folder, rather than the incremented name untitled_file_1/untitled_folder_1.

Copy link
Contributor

@ericpgreen2 ericpgreen2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving for you to merge after fixing the above-mentioned regression.

@AdityaHegde AdityaHegde force-pushed the adityahegde/file-explorer-drag-drop-fixes branch from 1a6d5a0 to 7e5e882 Compare April 17, 2024 06:14
@AdityaHegde AdityaHegde force-pushed the adityahegde/file-explorer-drag-drop-fixes branch from d88b651 to b344624 Compare April 17, 2024 06:21
@AdityaHegde AdityaHegde merged commit f458959 into main Apr 17, 2024
4 checks passed
@AdityaHegde AdityaHegde deleted the adityahegde/file-explorer-drag-drop-fixes branch April 17, 2024 06:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants