Runtime: Pass instanceID to drivers.Open for use in telemetry #4633
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactors the
drivers.Open
function signature:The
shared bool
args is replaced by a convention that a connection is considered shared ifinstanceID == ""
(this is clarified in docstrings throughout the PR).This change enables capturing the
instanceID
when a connection is opened (e.g. for use in telemetry). Previously, it had to be captured in the connection'sAs...
functions (as added in this PR), which is prone to race conditions, which are currently causing race tests to fail on main (example).