Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

File Explorer: small cleanups #4662

Merged
merged 10 commits into from
Apr 23, 2024
Merged

File Explorer: small cleanups #4662

merged 10 commits into from
Apr 23, 2024

Conversation

ericpgreen2
Copy link
Contributor

@ericpgreen2 ericpgreen2 commented Apr 19, 2024

  • Applies flex-none so carets and icons don't resize when the sidebar's width changes
  • Uses <a> elements not <button> element for file navigation; moves the context menu <button> outside of the <a> tag
  • Corrects the hover state for dotfiles
  • Modifies e2e tests to identify files with full file path
  • Adds a "No tables found" note for new projects without any tables
  • Improves the default Model and Dashboard files
  • Adds /.git as a protected directory

@ericpgreen2 ericpgreen2 self-assigned this Apr 19, 2024
@briangregoryholmes
Copy link
Contributor

briangregoryholmes commented Apr 19, 2024

Not sure if this PR was meant to address it, but the nav entries do still have nested interactive elements. The dropdown trigger is inside the <a> tag.

@ericpgreen2
Copy link
Contributor Author

Not sure if this PR was meant to address it, but the nav entries do still have nested interactive elements. The dropdown trigger is inside the <a> tag.

Oh, missed that – fixed.

@ericpgreen2 ericpgreen2 merged commit b9b78d3 into main Apr 23, 2024
4 checks passed
@ericpgreen2 ericpgreen2 deleted the file-explorer-details branch April 23, 2024 05:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants