Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle errors when rendering the PreviewTable #4677

Merged
merged 2 commits into from
Apr 22, 2024

Conversation

ericpgreen2
Copy link
Contributor

Previously, we weren't handling errors when rendering a Preview Table. This became apparent when a ClickHouse table contained some invalid UTF-8 strings. This PR shows an error message in these circumstances.

Closes #4542

Before:

image

After:

image

@ericpgreen2 ericpgreen2 self-assigned this Apr 22, 2024
@ericpgreen2
Copy link
Contributor Author

Code Review Agent Run Status

  • AI Based Review: Successful

Code Review Overview

  • Summary: The PR introduces error handling for rendering the PreviewTable in scenarios where invalid UTF-8 strings are encountered in a ClickHouse table. It adds a new component, WorkspaceError, across multiple Svelte files to display error messages effectively. This change enhances user experience by providing clearer error messages instead of failing silently or showing corrupted data.
  • Code change type: Feature Addition, UI/UX Improvement
  • Unit tests added: False
  • Estimated effort to review (1-5, lower is better): 2 - The changes are straightforward and localized but need to verify the integration across different components.

>>See detailed code suggestions<<
The Bito AI Code Review Agent successfully reviewed 5 files and discovered no issues.

High-level Feedback

Overall, the PR effectively addresses the issue of handling rendering errors due to invalid UTF-8 strings. It maintains consistency in user experience by introducing a dedicated error component. However, the absence of unit tests for the new error handling logic is a notable omission. Including tests would ensure reliability and catch potential edge cases.

@ericpgreen2 ericpgreen2 merged commit 810424a into main Apr 22, 2024
6 checks passed
@ericpgreen2 ericpgreen2 deleted the handle-tables-with-invalid-utf-8 branch April 22, 2024 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rill Developer: Show an error message for invalid UTF-8 strings
2 participants