Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rill Developer: Hide Sources & Models for ClickHouse & Druid #4684

Merged
merged 1 commit into from
Apr 24, 2024

Conversation

ericpgreen2
Copy link
Contributor

  • Sources & Models are not currently supported for ClickHouse- and Druid-backed projects
  • This PR hides the Sources & Models options in the "Add [resource]" button when the application is started with either of these OLAP engines.

@ericpgreen2 ericpgreen2 self-assigned this Apr 22, 2024
@ericpgreen2 ericpgreen2 requested a review from AdityaHegde April 24, 2024 00:32
@AdityaHegde AdityaHegde merged commit 483175e into main Apr 24, 2024
6 checks passed
@AdityaHegde AdityaHegde deleted the hide-sources-models-for-clickhouse-druid branch April 24, 2024 06:22
@AndrewRTsao
Copy link
Contributor

@ericpgreen2 Will this still be true now that Pinot is an available OLAP engine?

@ericpgreen2
Copy link
Contributor Author

@ericpgreen2 Will this still be true now that Pinot is an available OLAP engine?

Oh, we currently have this configuration to determine whether the OLAP driver supports sources & models. I haven't heard – should we add Pinot to that list?

@AndrewRTsao
Copy link
Contributor

Might be worth double checking with @nishantmonu51 or @begelundmuller but we just added support for Pinot as a new OLAP engine and I don't think we can support modeling there either.

@begelundmuller
Copy link
Contributor

Might be worth double checking with @nishantmonu51 or @begelundmuller but we just added support for Pinot as a new OLAP engine and I don't think we can support modeling there either.

Yeah it doesn't support modeling at the moment.

@ericpgreen2
Copy link
Contributor Author

Yeah it doesn't support modeling at the moment.

Sounds good. PR here: #4772. @begelundmuller, tagged you for review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants