Fix issues around unnest in dashboard #4690
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AdityaHegde
force-pushed
the
multiple-unnest-fix
branch
from
06819eb
to
2ce80e4
Compare
AdityaHegde
force-pushed
the
multiple-unnest-fix
branch
from
5d65f4c
to
f0675a1
Compare
AdityaHegde
force-pushed
the
multiple-unnest-fix
branch
from
f0675a1
to
a3f9fdd
Compare
runtime/drivers/olap.go
Outdated
Comment on lines
204
to
206
| func tempName(prefix string) string { | ||
| return prefix + strings.ReplaceAll(uuid.New().String(), "-", "") | ||
| } |
There was a problem hiding this comment.
Put util function at the end, see style guide: https://github.com/uber-go/guide/blob/master/style.md#function-grouping-and-ordering
begelundmuller
approved these changes
Apr 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #4691 , #4686