Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix label for dimensions in pivot #4704

Merged
merged 3 commits into from
Apr 25, 2024
Merged

Conversation

djbarnwal
Copy link
Member

For dimension label in pivot where name and column are different.

Fixes https://github.com/rilldata/rill-private-issues/issues/248

Copy link
Contributor

@ericpgreen2 ericpgreen2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like this fixed the issue in the pivot table body. Though, when coming from TDD, I'm seeing the measure & dimension pills are using the name not the label. Approving for you to merge when you like.

image

@djbarnwal djbarnwal merged commit bcded95 into main Apr 25, 2024
4 checks passed
@djbarnwal djbarnwal deleted the fix/label-for-pivot-dimension branch April 25, 2024 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants