Add ignore_paths support in rill.yaml #4708
Conversation
runtime/compilers/rillv1/init.go
Outdated
| ignoredPaths := "ignored_paths:\n- /.idea\n- /.vscode" // TODO: get a list from product | ||
| rillYAML := fmt.Sprintf("compiler: %s\n\ntitle: %q\n\n%s\n\n%s\n\n%s", Version, title, mockUsersInfo, mockUsers, ignoredPaths) |
There was a problem hiding this comment.
What do you think about not adding it by default to avoid clutter? And just describing it in the docs. (Assuming our defaults are good enough for most people.)
There was a problem hiding this comment.
This was the ask from product. But if we have hardcoded paths then this might not be necessary. @mindspank Any comments?
There was a problem hiding this comment.
Hmm feels like with our hardcoded paths we don't need defaults in rill.yaml
runtime/drivers/repo.go
Outdated
| // ignoredPaths is a list of paths that are ignored by the parser. | ||
| var ignoredPaths = []string{ | ||
| "/tmp", | ||
| "/.git", | ||
| "/node_modules", | ||
| } |
There was a problem hiding this comment.
Let's also add .DS_Store.
Can you think of others that would be nice?
There was a problem hiding this comment.
Editor folders is what came to my mind. Not sure if it would go to the hardcoded paths of configured one.
There was a problem hiding this comment.
Having editor folders here makes sense to me – don't see any reason people would ever want to edit .vscode inside of Rill :)
There was a problem hiding this comment.
Cool. I will move .vscode and .idea here from the init.
* Add ignore_paths support in rill.yaml * Add parsing of rill.yaml upfront * Cleanup IsIgnored from parser * Make the initial parse ignore errors * Update admin driver * PR comments
We want to allow users to ignore certain paths through rill.yaml. A new config
ignore_pathswill be added.ignore_paths.ignore_pathsin file driver.ignore_pathsin admin driver.