Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-use the Cloud error page in Rill Developer #4716

Merged
merged 3 commits into from
Apr 26, 2024
Merged

Re-use the Cloud error page in Rill Developer #4716

merged 3 commits into from
Apr 26, 2024

Conversation

ericpgreen2
Copy link
Contributor

This PR:

  • Moves the Rill Cloud error page to web-common, so it can be re-used for Rill Developer
  • Adds a fallback error page for Rill Developer at web-local/src/routes/+error.svelte
  • Handles parse errors triggered from an external IDE on the Rill Dev Preview Dashboard page

Addresses a couple comments here.

A couple things I noticed, but will keep out of this PR:

  • We should rework the CTAButton to accept an href.
  • One file write triggers multiple refetches of the Project Parser resource. Our resource invalidation really needs an audit.

@ericpgreen2 ericpgreen2 self-assigned this Apr 25, 2024
@ericpgreen2 ericpgreen2 merged commit f8fc521 into main Apr 26, 2024
6 checks passed
@ericpgreen2 ericpgreen2 deleted the rill-dev-error-page branch April 26, 2024 05:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@briangregoryholmes briangregoryholmes briangregoryholmes approved these changes

Assignees

@ericpgreen2 ericpgreen2

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ericpgreen2 @briangregoryholmes