Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Move /welcome route to application group #4721

Merged
merged 4 commits into from
Apr 26, 2024

Conversation

briangregoryholmes
Copy link
Contributor

@briangregoryholmes briangregoryholmes commented Apr 26, 2024

The Welcome page makes use of the Add Source Modal and FileDrop functionality, so it needs to be in the (application) scope of the routing tree. This is a quick PR that just moves the folder as is.

@briangregoryholmes briangregoryholmes self-assigned this Apr 26, 2024
@briangregoryholmes briangregoryholmes added Type:Bug Something isn't working blocker A release blocker issue that should be resolved before a new release labels Apr 26, 2024
@briangregoryholmes briangregoryholmes changed the title Fix: Move add source modal Fix: Move AddSourceModal and FileDrop Apr 26, 2024
@briangregoryholmes briangregoryholmes changed the title Fix: Move AddSourceModal and FileDrop Fix: Move /welcome route to application group Apr 26, 2024
@briangregoryholmes briangregoryholmes merged commit 6be3f7e into main Apr 26, 2024
4 checks passed
@briangregoryholmes briangregoryholmes deleted the bgh/add-source-modal-move branch April 26, 2024 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocker A release blocker issue that should be resolved before a new release Type:Bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants