Runtime: Dashboard components with generic renderers and optional inline definition #4735
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
begelundmuller
commented
Apr 26, 2024
| uint32 x = 2; | ||
| uint32 y = 3; | ||
| uint32 width = 4; | ||
| uint32 height = 5; | ||
| string markdown = 6; | ||
| uint32 font_size = 7; |
There was a problem hiding this comment.
Should this stay in the DashboardComponent or be moved to the renderer_properties for the markdown renderer? If the latter, it may require a syntax change since currently it's:
kind: component
markdown: Hello worldnot:
kind: component
markdown:
contents: Hello world
font_size: 12Another idea is to not support a separately defined font size and let people do it within Markdown using for example <span> tags?
begelundmuller
commented
Apr 29, 2024
AdityaHegde
approved these changes
Apr 29, 2024
* Update to use new API * Fix add chart * Fix AI generate chart * Fix lint
k-anshul
pushed a commit
that referenced
this pull request
Apr 30, 2024
…ine definition (#4735) * Runtime: Dashboard components with generic renderers and optional inline definition * Change "components" to "items" in the dashboard YAML * UI changes for updated Dashboard Component specs (#4744) * Update to use new API * Fix add chart * Fix AI generate chart * Fix lint * Fix lint in web-admin --------- Co-authored-by: Aditya Hegde <adityahegderocks@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
components:property toitems:in the dashboard YAMLitem = component + grid infoChartresource toComponentitems[*].componentis astring, it is treated as a reference to an externally defined componentitems[*].componentis amap, it is treated as an inline component definitionrendererandrenderer_propertiesfields toComponent"renderer": "vega_lite", "rendererProperties": {"spec": "..."}"renderer": "markdown", "rendererProperties": {"contents": "..."}"renderer": "image", "rendererProperties": {"url": "..."}Componentresources called[dashboard name]--component[idx]/charts/{name}/dataAPI to/components/{name}/dataGenerateChartSpecAPI toGenerateRenderer. It now returns two values:rendererandrenderer_properties.See this design doc for the new component syntax.
This PR currently breaks the frontend since these are breaking changes.