Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add defined_in_dashboard=true on components defined from a dashboard #4748

Merged
merged 2 commits into from
Apr 30, 2024

Conversation

begelundmuller
Copy link
Contributor

Also fixes two small bugs:

  • Adding an empty item would panic
  • Handle name collision for the autogenerated component names

@begelundmuller begelundmuller self-assigned this Apr 29, 2024
@begelundmuller begelundmuller changed the title Add defined_in_dashboard=true on components defined from a dashboard Add defined_in_dashboard=true on components defined from a dashboard Apr 29, 2024
@AdityaHegde AdityaHegde merged commit 20bf79a into main Apr 30, 2024
7 checks passed
@AdityaHegde AdityaHegde deleted the begelundmuller/add-defined-in-dashboard branch April 30, 2024 03:49
k-anshul pushed a commit that referenced this pull request Apr 30, 2024
#4748)

* Add defined_in_dashboard=true on components defined from a dashboard

* Fix test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants