Update custom dashboard integration to new spec #4754
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AdityaHegde
reviewed
Apr 30, 2024
| export let instanceId: string; | ||
|
|
||
| $: resourceQuery = useResource( | ||
| instanceId, |
There was a problem hiding this comment.
Whats the idea of getting the instance id in the params? We have the global to avoid prop drilling.
There was a problem hiding this comment.
Nothing hard and fast here. Just an instinct to get implementation details out of what are essentially display components. The runtime global is likely to change structure in the future. It also just means that only one component is subscribing to the store as opposed to however many dashboard elements there are. Not critical, though.
AdityaHegde
approved these changes
Apr 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR tackles the most critical updates required to bring the Custom Dashboard up to date with the new spec.