Add Pinot connector to the UI #4796
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ericpgreen2
added
the
blocker
pjain1
approved these changes
May 2, 2024
pjain1
reviewed
May 2, 2024
| @@ -13,6 +13,7 @@ import ( | |||
|
|
|||
| func init() { | |||
| drivers.Register("pinot", driver{}) | |||
| drivers.RegisterAsConnector("pinot", driver{}) | |||
There was a problem hiding this comment.
this is required for it to be in list of connectors for display in UI ?
There was a problem hiding this comment.
Yes, it's there in clickhouse connector as well.
nishantmonu51
approved these changes
May 2, 2024
k-anshul
pushed a commit
that referenced
this pull request
May 7, 2024
* Add Pinot icon * Register Pinot as a connector * Refactor OLAP driver instructions / Add Pinot option
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4787