Add autosave toggle to fallback Editor component
#4830
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
briangregoryholmes
approved these changes
May 6, 2024
ericpgreen2
added a commit
that referenced
this pull request
May 16, 2024
* Remove unused `focusOnMount` * Rename to `ModelEditor` * `update` -> `save` * Add autosave toggle to fallback editor * Remember autosave selection * Add confirmation before leaving unsaved file * Move debounce logic into `Editor` * Hide autosave for `rill.yaml` and `.env` files * Add unsaved-changes indicator to file header * Move debounce constant to `editor/config.ts` * Fix unit test * Initialize `autosave` to `false` for `rill.yaml` and `.env` * Re-org props * Handle "Revert changes" * Remove comment * Review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR takes a few steps forward in refactoring the
Editorcomponents (#4688). This PR brings the fallbackEditormore into parity with the other editors (YAMLEditor,ModelEditor), so that we can ultimately use thisEditoras the one canonical editor, regardless of file/resource type.Specifically, this PR:
Editorrill.yamland.envfiles (given edits to these files can trigger source re-ingestion)Editorcomponent, so the "autosave" is debounced but explicit save actions (the "Save" button;CMD+s) are not.Editor