runtime-local auth support #4843
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cli/pkg/local/app.go
Outdated
| http.Error(w, "failed to exchange code for token", http.StatusInternalServerError) | ||
| return | ||
| } | ||
| // save token and redirect to home screen or TODO url provided in initial request i.e. initiateAuthFlow |
There was a problem hiding this comment.
Yes it would be nice if we could support a redirect parameter in initiateAuthFlow like we do in the admin auth endpoints.
There was a problem hiding this comment.
relying on front end to send origin as query param, if present then redirect back to this url otherwise /
There was a problem hiding this comment.
Can we call the parameter redirect=https://... instead of origin? Just to align naming with the admin's /auth/login endpoint:
rill/admin/server/auth/handlers.go
Line 94 in e14e6fe
There was a problem hiding this comment.
sure I can change the query param but in the Authenticator it needs to be called this as there is already a redirectURL field for auth flow
begelundmuller
approved these changes
May 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
~/.rill/credentials.yaml