Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat: Component Title/Subtitle #4897

Merged
merged 7 commits into from
May 16, 2024
Merged

Feat: Component Title/Subtitle #4897

merged 7 commits into from
May 16, 2024

Conversation

briangregoryholmes
Copy link
Contributor

@briangregoryholmes briangregoryholmes commented May 14, 2024 •
edited
Loading

This PR adds a subtitle property to a dashboard Component and renders it, along with the existing title property, when displaying a Chart component.

  • Doubles the default "width" of the dashboard canvas (maintains existing sizing for Chart View)
  • Renders a white background for markdown components
  • Changes the dashboard background color to slate-200
  • Updates the optimistic file mutation to match the new argument type

@briangregoryholmes briangregoryholmes self-assigned this May 14, 2024
@briangregoryholmes briangregoryholmes linked an issue May 14, 2024 that may be closed by this pull request
Feat: Title and Sub-Title for Dashboard Component #4741
Closed
@briangregoryholmes briangregoryholmes merged commit 6f96cb0 into main May 16, 2024
7 checks passed
@briangregoryholmes briangregoryholmes deleted the bgh/component-title branch May 16, 2024 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nishantmonu51 nishantmonu51 nishantmonu51 approved these changes

@AdityaHegde AdityaHegde Awaiting requested review from AdityaHegde

Assignees

@briangregoryholmes briangregoryholmes

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Feat: Title and Sub-Title for Dashboard Component
2 participants
@briangregoryholmes @nishantmonu51