Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rill Developer: consistent page titles #4922

Merged
merged 3 commits into from
May 17, 2024
Merged

Conversation

ericpgreen2
Copy link
Contributor

@ericpgreen2 ericpgreen2 commented May 16, 2024

Previously, we didn't have a document title for the /files/[...file] routes. The title is the browser tab's label. This was confusing when navigating pages because navigation to these pages would not be reflected in the browser tab's label.

This PR:

  • Uses the file name (e.g. my_source.yaml), not the asset name (e.g. my_source) as the document title for all code editor pages.
  • Moves file utils out of features/sources into features/entity-management
image

@ericpgreen2 ericpgreen2 self-assigned this May 16, 2024
@ericpgreen2 ericpgreen2 merged commit 4b8ec01 into main May 17, 2024
4 checks passed
@ericpgreen2 ericpgreen2 deleted the consistent-document-titles branch May 17, 2024 14:45
ericpgreen2 added a commit that referenced this pull request May 20, 2024
* Consistent document titles

* Fix import
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants