Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Connectors: make the Table Explorer connector-specific #4941

Merged
merged 7 commits into from
May 23, 2024

Conversation

ericpgreen2
Copy link
Contributor

@ericpgreen2 ericpgreen2 commented May 22, 2024

This PR sets us up to add table/bucket discovery for multiple connectors at once.

This PR:

  • Reframes the "Tables" Explorer as a "Connector" Explorer
  • Lists out each connector in the project (but actually, for now, only shows the OLAP connector)
  • Nests the existing TableExplorer within a connector entry

Next, we will add support for browsing buckets from connected object stores and for browsing tables from connected non-OLAP databases (e.g. Postgres, BigQuery, Snowflake).

image

image

@ericpgreen2 ericpgreen2 self-assigned this May 22, 2024
@ericpgreen2 ericpgreen2 marked this pull request as ready for review May 22, 2024 19:27
@briangregoryholmes
Copy link
Contributor

LGTM

@ericpgreen2 ericpgreen2 merged commit cc65cda into main May 23, 2024
4 checks passed
@ericpgreen2 ericpgreen2 deleted the connector-explorer-v0 branch May 23, 2024 03:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants