Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Connectors: Add hierarchy to Table Explorer #4975

Merged
merged 5 commits into from
Jun 1, 2024

Conversation

ericpgreen2
Copy link
Contributor

@ericpgreen2 ericpgreen2 commented May 29, 2024

This PR adds hierarchy to the Table Explorer.

Specifically, this PR:

  • Represents databases and database schemas in an expandable/collapsible folder structure
  • Moves the code from features/tables to features/connectors/olap in anticipation of more connector-specific functionality

image

image

@ericpgreen2 ericpgreen2 self-assigned this May 29, 2024
@nishantmonu51 nishantmonu51 added the blocker A release blocker issue that should be resolved before a new release label May 30, 2024
@ericpgreen2 ericpgreen2 marked this pull request as ready for review June 1, 2024 05:43
@ericpgreen2 ericpgreen2 merged commit 5c2e3b8 into main Jun 1, 2024
4 checks passed
@ericpgreen2 ericpgreen2 deleted the olap-table-explorer-with-hierarchy branch June 1, 2024 19:18
nishantmonu51 pushed a commit that referenced this pull request Jun 3, 2024
* Add `database` > `databaseSchema` > `table` hierarchy to our OLAP Table Explorer

* Make the left-padding a function of the `database` presence

* Use a database icon, not folder icon, for 2-layer hierarchies

* Slight improvement & clarification of scroll & sticky headers
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocker A release blocker issue that should be resolved before a new release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants