Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: stale pivot data on config change #4994

Merged
merged 1 commit into from
Jun 1, 2024
Merged

Fix: stale pivot data on config change #4994

merged 1 commit into from
Jun 1, 2024

Conversation

djbarnwal
Copy link
Member

Fixes #4942

Makes two changes -

  1. For pivot table with rows less than 50 do not change row page number on scroll
  2. When the pivot config changes (ex- time range, comparison range etc.) update rowPage to 1.

@djbarnwal djbarnwal added the blocker A release blocker issue that should be resolved before a new release label May 31, 2024
@nishantmonu51 nishantmonu51 merged commit 3f54f66 into main Jun 1, 2024
6 checks passed
@nishantmonu51 nishantmonu51 deleted the fix/pivot-stale-data branch June 1, 2024 19:49
nishantmonu51 pushed a commit that referenced this pull request Jun 3, 2024
@djbarnwal @nishantmonu51
Fix: stale pivot data on config change (#4994)
7b5b631
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@briangregoryholmes briangregoryholmes briangregoryholmes approved these changes

@nishantmonu51 nishantmonu51 nishantmonu51 approved these changes

Assignees
No one assigned
Labels
blocker A release blocker issue that should be resolved before a new release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Pivot table does not update on changing time after scroll
3 participants
@djbarnwal @nishantmonu51 @briangregoryholmes