Connectors: Handle arbitrary names #5015
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ericpgreen2
added
the
blocker
AdityaHegde
approved these changes
Jun 4, 2024
| @@ -23,8 +24,4 @@ | |||
| <title>Rill Developer | {table}</title> | |||
| </svelte:head> | |||
|
|
|||
| <TablePreviewWorkspace | |||
There was a problem hiding this comment.
Any reason to keep individual pages for different connectors?
There was a problem hiding this comment.
I originally did it because each database has its own specific hierarchy (see below), but actually we might be able to use a [...catchall] route. I'll try that after we get the release out.
ericpgreen2
added a commit
that referenced
this pull request
Jun 4, 2024
* Change routes to include the connector's `name` * Use the table name (not fully qualified name) in the workspace header * Include connector name in table identifier * Error handling * Fix link * Bugfix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a small refactor to handle arbitrary connector names in the UI. This sets us up to allow >1 connector per connector type/driver.
For illustration, here's a connector not named the same as its driver: