Add instance annotations to data_dir_size_bytes metric #5046
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
begelundmuller
requested changes
Jun 10, 2024
runtime/registry.go
Outdated
Comment on lines
544
to
547
| // Add instance annotations as attributes to pass organization id, project id, etc. | ||
| for k, v := range inst.Annotations { | ||
| attrs = append(attrs, attribute.String(k, v)) | ||
| } |
There was a problem hiding this comment.
Consider using instanceAnnotationsToAttribs to avoid duplicated logic
runtime/registry.go
Outdated
| attribute.String("instance_id", inst.ID), | ||
| attribute.String("updated_on", inst.UpdatedOn.Format(time.RFC3339)), | ||
| ) | ||
| attribute.String("updated_on", inst.UpdatedOn.Format(time.RFC3339))) |
There was a problem hiding this comment.
Let's omit this – it made sense for the wide events, but not really for metrics events (would be a separate metric if anything)
begelundmuller
approved these changes
Jun 10, 2024
esevastyanov
added a commit
that referenced
this pull request
Jun 10, 2024
* Add instance annotations to data_dir_size_bytes metric * instanceAnnotationsToAttribs (cherry picked from commit 56b546c)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.